Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-delimiters incorrectly matched #27

Open
verdy-p opened this issue Sep 17, 2022 · 1 comment
Open

Sub-delimiters incorrectly matched #27

verdy-p opened this issue Sep 17, 2022 · 1 comment

Comments

@verdy-p
Copy link

verdy-p commented Sep 17, 2022

The closing brace } is NOT allowed as a valid "sub-delim" character, but the closing parenthese ) is missing.

See RFC RFC3986 annex A, and pull request #26

@verdy-p
Copy link
Author

verdy-p commented Oct 1, 2022

Note that with this change, you could still not support ODBC-style DSN's (which require {} braces as alternate delimiters to enclose names containing spaces or as a way to enclose and escape other delimiters) like:
Driver={ODBC Driver 13 for SQL Server};server=localhost;database=WideWorldImporters;trusted_connection=Yes;

But a few other DSN's would be working now (notably those using () parentheses). May be braces could be allowed as well (but the current code does not check their pairing for correct enclosure: this requires an additional validation rule that cannot use basic regexps, but requires a stack for LALR parsing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant