Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to php 8.1? Blocker for Carson #4

Closed
weaverryan opened this issue Dec 5, 2022 · 2 comments · Fixed by #5
Closed

Upgrade to php 8.1? Blocker for Carson #4

weaverryan opened this issue Dec 5, 2022 · 2 comments · Fixed by #5

Comments

@weaverryan
Copy link

Hi!

Could you upgrade this to work with PHP 8.1? We need it of carson is to use 8.1. Currently, if I update the deps, I receive this error:

Uncaught TypeError: Github\HttpClient\Builder::__construct(): Argument #2 ($requestFactory) must be of type ?Psr\Http\Message\RequestFactoryInterface, Nyholm\Psr7\Factory\HttplugFactory given, called in /private/var/folders/ck/flmtvlh94bz_p8191nwkf1ph0000gn/T/git-reviewer/cache/prod/container.php on line 130 and defined in /Users/weaverryan/Sites/os/git-reviewer/vendor/knplabs/github-api/lib/Github/HttpClient/Builder.php:80

I don't have a good idea of how to fix this :)

Cheers!

@OskarStark
Copy link

Any news here @Nyholm it would be cool to be able to give carsonbot some love and newer PHP

@Nyholm
Copy link
Owner

Nyholm commented Jan 4, 2024

Let's drop the git-reviewer feature. It wasn't as well received as I thought.

@Nyholm Nyholm mentioned this issue Jan 8, 2024
@Nyholm Nyholm closed this as completed in #5 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants