Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSubReader should detect idle topic and propagate it to watermark estimator #154

Open
tisonet opened this issue Jun 4, 2020 · 0 comments
Open

PubSubReader should detect idle topic and propagate it to watermark estimator #154

tisonet opened this issue Jun 4, 2020 · 0 comments

Comments

@tisonet
Copy link
Contributor

tisonet commented Jun 4, 2020

PubSubReader doesn't fulfil the complete contract of Watermark estimator. The idle() method is not called when topic doesn't have more data.

Reader has to detect idle topic and propagates this signal to watermark estimator.
@tisonet tisonet mentioned this issue Jun 4, 2020
Merged
@tisonet tisonet changed the title PubSubReader detects idle topic and propagates it to watermark estimator PubSubReader should detect idle topic and propagate it to watermark estimator Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tisonet