Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: Allow empty array for parameters #305

Closed
webron opened this issue Mar 13, 2015 · 10 comments
Closed

Schema: Allow empty array for parameters #305

webron opened this issue Mar 13, 2015 · 10 comments
Assignees
Labels

Comments

@webron
Copy link
Member

webron commented Mar 13, 2015

No description provided.

@webron webron added the bug label Mar 13, 2015
@webron webron self-assigned this Mar 13, 2015
@mhamann
Copy link

mhamann commented Mar 23, 2015

So, this is being added to the spec? What's the timeline on this?

The petstore swagger.json on http://petstore.swagger.io is broken as a result of the change already being made to that file but not being referenced by the spec.

In the future, the spec really should be updated before the sample JSON is changed, since it will break anyone using it to test their products that are built against the spec.

@fehguy
Copy link
Contributor

fehguy commented Mar 23, 2015

Matt, it is a bug. This is an OSS project so if the response isn't fast enough please consider a PR. I don't like having defects but it is inevitable

@webron webron closed this as completed in 299aecb Mar 26, 2015
@webron
Copy link
Member Author

webron commented Mar 26, 2015

@mhamann - FWIW, the spec was correct, the schema wasn't.

@mhamann
Copy link

mhamann commented Mar 26, 2015

@webron, thanks for the clarification. Glad to see the validators passing too :-)

@JamesMessinger
Copy link
Contributor

When will the updated Swagger schema be published to NPM? The version on NPM is six months old and missing a lot of little fixes like this one.

@webron
Copy link
Member Author

webron commented Apr 20, 2015

@BigstickCarpet - which npm is that? I know I've never published anything there.

@JamesMessinger
Copy link
Contributor

@webron - I'm talking about swagger-schema-official. It looks like the npm package is owned by @mohsen1.

The package.json file is part of the Swagger-Spec codebase, so I assumed that meant the npm package was officially supported/managed by the Swagger team. Is that not the case?

@webron
Copy link
Member Author

webron commented Apr 20, 2015

There's something behind there. In any case, we'll look into publishing it soon, though a couple of more fixes are pending.

@JamesMessinger
Copy link
Contributor

👍 Cool, thanks!

@webron
Copy link
Member Author

webron commented Apr 20, 2015

It's actually help if you open a specific issue about it to make sure we remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants