Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparently wrong version downloads from releases v.2.14 #518

Closed
morkeltry opened this issue May 5, 2024 · 4 comments
Closed

Apparently wrong version downloads from releases v.2.14 #518

morkeltry opened this issue May 5, 2024 · 4 comments
Assignees
Labels
bug Something isn't working Stale

Comments

@morkeltry
Copy link

morkeltry commented May 5, 2024

Releases 2.14 binary and source code downloads apparently provide v.2.1.0-e07a5345066.

Steps to Reproduce

wget https://github.com/OAK-Foundation/OAK-blockchain/releases/download/v2.0.0/oak-collator
chmod +755 oak-collator
./oak-collator --version

oak-collator 2.1.0-e07a5345066

Calling system::version() extrinsic through https://polkadot.js.org/apps returns:

2.1.0-e07a5345066

OR

git clone https://github.com/OAK-Foundation/OAK-blockchain.git
cargo build --release --features turing-node --features dev-queue
./target/release/oak-collator --version

oak-collator 2.1.0-e07a5345066

and running Moonbeam EVM smart contract automation demo chokes on Error: The scheduleAs parameter should not be empty, which should not be present in v.2.1.4

Expected vs. Actual Behavior

oak-collator to report as, and operate as, v.2.1.4
vs
reports as oak-collator 2.1.0-e07a5345066 and does not include merged feature of v.2.1.4

Related issue
Moonbeam demo cannot work with required Turing version

@morkeltry morkeltry added the bug Something isn't working label May 5, 2024
@morkeltry morkeltry changed the title Apparently wrong version in [releases 2.14](https://github.com/OAK-Foundation/OAK-blockchain/releases/tag/v2.1.4) Apparently wrong version downloads from releases v.2.14 May 5, 2024
@chrisli30
Copy link
Member

chrisli30 commented May 5, 2024

@morkeltry thanks for your report and I apologize for the product experience you've had. We will investigate the issue today and get back to you shortly!

This is related to AvaProtocol/xcm-demo#113

@chrisli30
Copy link
Member

@morkeltry, the binary version oak-collator 2.1.0-e07a5345066 is correct and by design. Because the node client has not changed since 2.1.0, as you can view from the history of Releases, the binary filename still starts with 2.1.0. From v2.1.0 to v2.1.4, only blockchain runtime were updated, and there’s no requirement for node operator to update the oak-collator binary file.

Please let me know if that makes sense and there are more questions.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 12, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

3 participants