[9.0][account_move_base_import] Make commission line feature generic for all parsers #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-dacosta
force-pushed
the
9-fix-commission-for-specific-parser
branch
from
42e6006
to
623ec9f
Compare
bjeficent
pushed a commit
to ForgeFlow/account-reconcile
that referenced
this pull request
Dec 17, 2018
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that thecommission feature of the module account_move_base_import was only compatible the generec parser (
generic_csvxls_so) because the name of the column from the file is hardcodedcommission_amountAlso, I saw that the commission feature is not compatible with the
split_counterpartcounterpart option.This PR aims to fix these 2 issues