[ADD] Delivery Carrier Seur Module #76

ismaelcj · 2015-11-02T18:33:48Z

Seur module for generate:

Label and tracking number
Manifest

pedrobaeza · 2015-11-03T08:16:58Z

delivery_carrier_seur/README.rst

@@ -0,0 +1,39 @@
+Module for SEUR carrier labels


Please use latest README template: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

pedrobaeza · 2015-11-03T08:22:50Z

You should add seur library installatin in .travis.yml file.

pedrobaeza · 2015-11-03T08:24:01Z

Anyway, I can't see the usage of the seur python library in the code.

pedrobaeza · 2015-11-03T08:25:07Z

Another thing: is this only valid for Spain? If so, you should rename the module with the l10n_es_ prefix, and we have to think about placing this here, or in the l10n-spain repo.

ismaelcj · 2015-11-03T11:34:02Z

delivery_carrier_seur/model/stock.py

+##############################################################################
+from openerp import models, fields, api, exceptions
+from openerp.tools.translate import _
+from seur.picking import Picking


Here is the import of the Seur library. And i use it later.

OK, I didn't see it. Then you should protect the import following this guideline: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#importerror

General external dependencies guideline: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies

ismaelcj · 2015-11-03T11:36:09Z

The truth is I do not know if it's just for Spain.

pedrobaeza · 2015-11-03T16:00:56Z

For the deliver types, I would say it's only for Spain, so you should rename it to delivery_carrier_seur_es o l10n_es_delivery_carrier_seur. What others think?

liebana · 2015-11-03T17:15:41Z

SEUR also operates at least in Portugal.

pedrobaeza · 2015-11-03T17:23:18Z

But services name (SEUR 24 h, SEUR 8:30) seems very specific of Spain, doesn't it?

bealdav · 2015-11-20T16:09:03Z

Hi @ismaelcj , maybe this PR can help you to have less code

bealdav · 2015-11-20T16:29:25Z

delivery_carrier_seur/model/stock.py

+class StockPicking(models.Model):
+    _inherit = 'stock.picking'
+
+    seur_service_code = fields.Selection(


You may use carrier option mechanism to have a cleaner interface
https://github.com/OCA/carrier-delivery/blob/8.0/delivery_carrier_label_postlogistics/delivery.py#L76

yvaucher · 2015-12-04T16:50:42Z

delivery_carrier_seur/model/delivery.py

+        res.append(('seur', 'SEUR'))
+        return res
+
+    seur_config_id = fields.Many2one('seur.config', string='SEUR Config')


As it is configuration, wouldn't it be better to have a configuration menu ?

Could those config be setup on company, here is an example:
https://github.com/OCA/carrier-delivery/blob/8.0/delivery_carrier_label_postlogistics/company.py
https://github.com/OCA/carrier-delivery/blob/8.0/delivery_carrier_label_postlogistics/res_config_view.xml
https://github.com/OCA/carrier-delivery/blob/8.0/delivery_carrier_label_postlogistics/res_config.py

I don't know what you mean. It has a menu in Settings > Configuration > Carriers > SEUR

Usually configs are a transientmodel as it gather data from multiple origin and are linked to a company.

Here you seems to have a config shared by all companies that you can set on a specific delivery method.
In other delivery services we have a single account per company. With management of options on the delivery method.

Is there a reason to have multiple config for one company ?

yvaucher · 2015-12-04T17:25:04Z

Nice to see we are reaching spain with this repository, welcome here @ismaelcj

Thanks for your contribution.

I seems you need to add a python dependency "genshi" for travis
https://travis-ci.org/OCA/carrier-delivery/jobs/89049748

Also, it seems this module needs testing. Could you add some?
A good practice would be to use mock or even better https://github.com/kevin1024/vcrpy to simulate the talk with the webservice API

ismaelcj · 2015-12-23T17:32:40Z

Hi,

@yvaucher About your comment:

'I seems you need to add a python dependency "genshi" for travis'

It was an error on the API setup.py. I proposed the changes in the API repository, and are already applied:
https://bitbucket.org/zikzakmedia/python-seur/commits/f853056f21d506e68e526cf1ca2363334f0047d7

About the tests, I will to do it.

ismaelcj · 2015-12-23T17:38:54Z

The genshi dependence continuous falling in travis, I don't understand.

yvaucher · 2016-07-01T15:39:30Z

.travis.yml

@@ -35,6 +35,7 @@ install:
  - pip install unidecode
  - pip install pycountry
  - pip install suds-jurko==0.6
+  - pip install seur


have you tried to install genshi before seur ?

pip install genshi
pip install seur

angelmoya · 2017-04-11T06:51:08Z

I start to migrate this module to version 10, and i found two problems:

Now seur module suport timeout, and it's needed to set on calls, so with this code you get an error, you can check it on https://bitbucket.org/zikzakmedia/python-seur/pull-requests/2/readme-edited-online-with-bitbucket/diff
On this module you inherit from manifest wizard, but this module is on other PR, and this is not on dependencies.

I will create new PR for version 10

…amount Add expected amount and probability fields on building project

rousseldenis · 2019-05-28T15:08:18Z

@ismaelcj This one is really old. Do you plan to fix it ?

ismaelcj · 2019-05-28T15:34:32Z

Me not. Maybe @liebana or @hugosantosred or @kikopeiro

Refactor error handling

github-actions · 2021-10-24T12:23:32Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Refactor error handling

pedrobaeza reviewed Nov 3, 2015
View reviewed changes

ismaelcj reviewed Nov 3, 2015
View reviewed changes

bealdav reviewed Nov 20, 2015
View reviewed changes

yvaucher reviewed Dec 4, 2015
View reviewed changes

ismaelcj force-pushed the 8.0-seur branch from b50e02c to b9679c3 Compare December 23, 2015 17:10

[ADD] Delivery Carrier Seur Module

cec8868

ismaelcj force-pushed the 8.0-seur branch from b9679c3 to cec8868 Compare January 28, 2016 12:37

yvaucher reviewed Jul 1, 2016
View reviewed changes

yvaucher added the needs fixing label Jul 1, 2016

vrenaville pushed a commit to camptocamp/delivery-carrier that referenced this pull request Jul 2, 2018

Merge pull request OCA#76 from yvaucher/add-fields-prob-and-expected-…

b18a1fe

…amount Add expected amount and probability fields on building project

OCA-git-bot pushed a commit that referenced this pull request Jul 3, 2021

Refactore error handling (#76)

9a7a0df

Refactor error handling

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021

github-actions bot closed this Nov 28, 2021

OCA-git-bot pushed a commit that referenced this pull request Oct 4, 2023

Refactore error handling (#76)

5a89027

Refactor error handling

OCA-git-bot pushed a commit that referenced this pull request Oct 4, 2023

Refactore error handling (#76)

deaa30d

Refactor error handling

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] Delivery Carrier Seur Module #76

[ADD] Delivery Carrier Seur Module #76

ismaelcj commented Nov 2, 2015

pedrobaeza Nov 3, 2015

pedrobaeza commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

ismaelcj Nov 3, 2015

pedrobaeza Nov 3, 2015

pedrobaeza Nov 3, 2015

ismaelcj commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

liebana commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

bealdav commented Nov 20, 2015

bealdav Nov 20, 2015

yvaucher Dec 4, 2015

ismaelcj Dec 23, 2015

yvaucher May 5, 2017 •

edited

yvaucher commented Dec 4, 2015

ismaelcj commented Dec 23, 2015

ismaelcj commented Dec 23, 2015

yvaucher Jul 1, 2016

angelmoya commented Apr 11, 2017

rousseldenis commented May 28, 2019

ismaelcj commented May 28, 2019

github-actions bot commented Oct 24, 2021

[ADD] Delivery Carrier Seur Module #76

[ADD] Delivery Carrier Seur Module #76

Conversation

ismaelcj commented Nov 2, 2015

Choose a reason for hiding this comment

pedrobaeza commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ismaelcj commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

liebana commented Nov 3, 2015

pedrobaeza commented Nov 3, 2015

bealdav commented Nov 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yvaucher May 5, 2017 • edited

Choose a reason for hiding this comment

yvaucher commented Dec 4, 2015

ismaelcj commented Dec 23, 2015

ismaelcj commented Dec 23, 2015

Choose a reason for hiding this comment

angelmoya commented Apr 11, 2017

rousseldenis commented May 28, 2019

ismaelcj commented May 28, 2019

github-actions bot commented Oct 24, 2021

yvaucher May 5, 2017 •

edited