Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account_invoice_overdue_reminder: Add credit notes to overdue e-mail #226

Merged
merged 4 commits into from
Apr 30, 2023

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Oct 27, 2022

Fixes #211

Screenshot. I am not a UI designer.

Capture d’écran du 2022-11-30 15-17-31

(I added a 'type' column. Maybe it's not necessary.)

Internal task: https://gestion.coopiteasy.be/web#id=9074&action=479&model=project.task&view_type=form&menu_id=536

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

Copy link

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@alexis-via, @sergiocorato : could you take a look on this one ?

Copy link

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiocorato
Copy link

To proceed to merge the branch needs to be upgraded to copier template, I'll do it.

@sergiocorato
Copy link

@legalsylvain @alexis-via @carmenbianca I added #232 to fix this.

@carmenbianca
Copy link
Member Author

Changed the colour to LightGray.

Also fixed a restraint.

@legalsylvain
Copy link

Could you rebase ?

…-mail

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
Copy link
Member Author

@legalsylvain rebased

@alexis-via could you merge this when you next have time?


n.b. future users -> the mail template is marked noupdate. In order to get the new mail template, you have to run odoo [...] -i account_invoice_overdue_reminder. furthermore, the translations are not yet done.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 2, 2023
@carmenbianca
Copy link
Member Author

Bump :)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 23, 2023
@vdewulf
Copy link

vdewulf commented Apr 30, 2023

@carmenbianca what needs to be done to get this merged? thx!

@rvalyi
Copy link
Member

rvalyi commented Apr 30, 2023

hello as usual I guess we lack of reviewer and active repo PSC'... PRs authors can also always increase their chance to get a review by helping the module maintainers/authors or key reviewers in some of their own PRs but people like Alexis are busy like hell anyway...

Based on the reviews and the fact you discussed the feature with @alexis-via the module author I'll merge it tough. Would be cool if you could port it to newer versions too. To be honest chances Alexis review PRs on v13 or v15s are low, but v14 and v16 PRs would have a chance.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-226-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2f7de97 into OCA:12.0 Apr 30, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a9f7f1. Thanks a lot for contributing to OCA. ❤️

@vdewulf
Copy link

vdewulf commented May 2, 2023

@rvalyi thanks a lot! @carmenbianca will port this to v14 as suggested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants