-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] account_invoice_overdue_reminder: Add credit notes to overdue e-mail #226
Conversation
Hi @alexis-via, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
@alexis-via, @sergiocorato : could you take a look on this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To proceed to merge the branch needs to be upgraded to copier template, I'll do it. |
@legalsylvain @alexis-via @carmenbianca I added #232 to fix this. |
Changed the colour to LightGray. Also fixed a restraint. |
Could you rebase ? |
…-mail Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
d42e914
to
d676080
Compare
@legalsylvain rebased @alexis-via could you merge this when you next have time? n.b. future users -> the mail template is marked noupdate. In order to get the new mail template, you have to run |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Bump :) |
@carmenbianca what needs to be done to get this merged? thx! |
hello as usual I guess we lack of reviewer and active repo PSC'... PRs authors can also always increase their chance to get a review by helping the module maintainers/authors or key reviewers in some of their own PRs but people like Alexis are busy like hell anyway... Based on the reviews and the fact you discussed the feature with @alexis-via the module author I'll merge it tough. Would be cool if you could port it to newer versions too. To be honest chances Alexis review PRs on v13 or v15s are low, but v14 and v16 PRs would have a chance. /ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7a9f7f1. Thanks a lot for contributing to OCA. ❤️ |
@rvalyi thanks a lot! @carmenbianca will port this to v14 as suggested! |
Fixes #211
Screenshot. I am not a UI designer.
(I added a 'type' column. Maybe it's not necessary.)
Internal task: https://gestion.coopiteasy.be/web#id=9074&action=479&model=project.task&view_type=form&menu_id=536