[14.0]account_invoice_overdue_reminder : When i remove invoice from list in wizard, the residual become 0

[Olimalt85]

Module

account_invoice_overdue_reminder

Describe the bug

When you use the reminder wizard in customers and delete a line from the invoice_ids field, the computed amount due of each line become 0

When i remove a line on invoice :

To Reproduce

Affected versions: 14.0

Steps to reproduce the behavior:

1. Launch the action "Overdue Invoice Remind" in Invoicing/Customers/Overdue Invoice Remind
2. Start the action
3. Delete a line in the invoices list

Expected behavior
The residual amount should be computed normaly.

[Olimalt85]

I found that the problem was because of the mail template creation.

To debug it, i made a method "_get_mail_template" in the wizard that return the mail template like this :

And i had to change the lines related to the td of amount_untaxed,amount_total and amount_residual :
<td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_untaxed * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td> <td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_total * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td> <td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_residual * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td>

I just add _signed after the fields names to resolve it.
Like this :
<td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_untaxed_signed * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td> <td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_total_signed * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td> <td style="padding: 5px; border: 1px solid black; text-align: right;">${format_amount(inv.amount_residual_signed * (inv.move_type == 'out_refund' and -1 or 1), inv.currency_id)}</td>

But when i try to change the mail template directly like this, it won't work i don't understand why?

[Olimalt85]

I found the last problem, it was caused by the "total_residual" function.
I had to change inv.amount_residual by inv.amount_residual_signed in it :

its now working well !

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.