[ADD] Module to send out timesheet notifications and subscribe the employee's manager #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cr, uid, 'hr_timesheet_notifications', 'subtype_confirm')[1], | ||
| ] | ||
|
|
||
| if sheet.employee_id.parent_id.user_id: |
There was a problem hiding this comment.
Has an employee always a supervisor? On contrary, this will fail.
|
A little question, but the rest 👍 |
|
You're absolutely right, I need to check parent_id first as it is not a required field. Thanks! |
|
As a note, with v8, this is not needed, because it propagates False (or [] for one2many and many2many) through empty recordset, avoiding these long expressions. |
|
@StefanRijnhart is this PR still in WIP state? |
StefanRijnhart
force-pushed
the
7.0-subscribe_manager
branch
from
f80def8
to
3dd9b55
Compare
|
Rebased and fixed bug signalled by @pedrobaeza. Thank you for your patience! |
|
Thanks again 👍 |
|
👍 |
max3903
pushed a commit
that referenced
this pull request
Sep 18, 2015
[ADD] Module to send out timesheet notifications and subscribe the employee's manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.