[FIX] Update hs_code to hs_code_id #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexis-via @luc-demeyer If I can have your review? |
1 similar comment
gurneyalex
requested changes
Jul 25, 2017
There was a problem hiding this comment.
This cannot work : in delivery the field hs_code = fields.Char
You cannot change the field type like you do. IMO, you should
- change the field hs_code to be a related field (readonly) to use the hs code name from this module
- change the form to hide the hs_code field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In odoo/delivery you can find the hs_code field. It is also introduced by https://github.com/OCA/intrastat/blame/10.0/product_harmonized_system/views/product_template.xml#L17 in the product.template view.
The goal of this PR is to use the same name for this field in OCA and Odoo's base code source.