11.0 mig product harmonized system #38
Conversation
…n intrastat This code has been written both by Luc de Meyer and myself.
Copy incoterms and destination country from SO to invoice when invoicing from SO We need weight even when supplementary units is used Small cleanups and enhancements
Add default values for intrastat transaction on company Code cleanup
Rename variables
Set 2 other modules to uninstallable Update README.rst: switch to new intrastat project
Special thanks to Pedro and Holger for finding the solution for display_name Fix demo data
There was a problem hiding this comment.
Could you also add the readme files? See latest template https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
| </record> | ||
|
|
||
| <!-- Menu entry for H.S. code --> | ||
| <!-- TODO: find a way to put a menu entry without depending on another module ? |
There was a problem hiding this comment.
An idea could be adding a button or a link in the 'res.config.settings' that triggers the hs_code_action. This way you don't need to depend on another module.
| @@ -0,0 +1,30 @@ | |||
| # © 2018 brain-tec AG (http://www.braintec-group.com) | |||
There was a problem hiding this comment.
Could you replace the symbol © with the string Copyright in the headers?
| "available from the World Customs Organisation, see " | ||
| "http://www.wcoomd.org") | ||
| description = fields.Char( | ||
| 'Description', translate=True, |
| compute='_compute_display_name_field', string="Display Name", | ||
| store=True, readonly=True) | ||
| local_code = fields.Char( | ||
| string='Local Code', required=True, |
| 'Description', translate=True, | ||
| help="Short text description of the H.S. category") | ||
| display_name = fields.Char( | ||
| compute='_compute_display_name_field', string="Display Name", |
There was a problem hiding this comment.
No need of string="Display Name"
There was a problem hiding this comment.
Code review & tested.
Remarks of @astirpe are valuable hence would be nice to include but imho not blocking for merging this PR.
There was a problem hiding this comment.
@luc-demeyer ... however it's stated in the OCA Guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#fields
There was a problem hiding this comment.
@astirpe I fully agree, hence if @rvalyi is prepared to adjust the PR accordingly than it's aligned more closely to the OCA guidelines. Imho not blocking though for merge. I prefer to have this one merged asap so that we can focus on the larger work (port of intrastat_product for which I would first like to have a couple of major fixes and enhancements in the 10.0 version merged and use this as the basis for the port).
supersedes #29
additionally, it
cc @BT-kaberer @feketemihai @alexis-via @astirpe @luc-demeyer