Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We may have to refactor the res_partnew_views.xml a bit #4

Closed
eternalharvest opened this issue Apr 12, 2018 · 2 comments
Closed

We may have to refactor the res_partnew_views.xml a bit #4

eternalharvest opened this issue Apr 12, 2018 · 2 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@eternalharvest
Copy link
Contributor

Description

I'm currently proposing a new PR in odoo official repo (odoo/odoo#24199)
This PR introduces 'format.address.mixin' into company and bank model so that we can localize address layout easily.
But it has some problem with this l10n_jp_address_layout module.

So, I think we need to remove some field and attrs from `res_partner_views.xml'.
But I'm not sure whether if these invisible fields and attrs conditions are really needed or not.
Please advise me!

https://github.com/OCA/l10n-japan/blob/11.0/l10n_jp_address_layout/views/res_partner_views.xml#L10-L11

Thanks, Regrads

@yostashiro
Copy link
Sponsor Member

@eternalharvest I commented in your PR here: odoo/odoo#24199 (comment)

I'm afraid Odoo will most likely not accept your PR as it is because of the conflict you are aware of. They might consider merging your it for the next version if you get to complete the design, but not for the current stable version I'm certain.

But I'm not sure whether if these invisible fields and attrs conditions are really needed or not.

Yes, these are needed to control the behavior. :)

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants