Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Disable Pylint checks on __unported__ #157

Closed
yvaucher opened this issue Dec 16, 2014 · 11 comments
Closed

Disable Pylint checks on __unported__ #157

yvaucher opened this issue Dec 16, 2014 · 11 comments

Comments

@yvaucher
Copy link
Member

In OCA/connector-magento#75 I encounter pylint check on __unported__ dir I don't think we want to check that directory too.

@dreispt
Copy link
Sponsor Member

dreispt commented Dec 16, 2014

That shouldn't be so.
@moylop260 can you check?

@dreispt dreispt added the bug label Dec 16, 2014
@pedrobaeza
Copy link
Member

That it's not supposed to happen...

@moylop260
Copy link
Contributor

@yvaucher
Sorry for delay.
I need more information.
Can you give me a build link of travis with problem, please?

@dreispt
Copy link
Sponsor Member

dreispt commented May 15, 2015

I'm not aware of this being an issue right now. I vote to close.

@pedrobaeza
Copy link
Member

@pedrobaeza
Copy link
Member

@moylop260
Copy link
Contributor

@pedrobaeza
Do you have a travis build where pylint check __unported__ folder?
pylint don't check paths if not exists a python package (__init__.py in root path).

@moylop260
Copy link
Contributor

I found next case:
travis build with unported checks

I saw next folder structure in __unported__ folder:
unported

I did not know that we added __init__.py file to __unported__ folder.
Is required this structure for you?

@moylop260
Copy link
Contributor

I saw this change of @guewen:
OCA/connector-magento@e8ad2d8#diff-68a29d45b5dc96e3451c43107948f08a

I detect next case:

File renamed without changes
customize_example/__init__.py → __unported__/__init__.py

IMHO this should be:

File renamed without changes
customize_example/__init__.py → __unported__/customize_example/__init__.py

@moylop260
Copy link
Contributor

IMHO this is a expected error of pylint.
I will close this issue.
Feel free to reopen if you consider it necessary.

@guewen
Copy link
Member

guewen commented May 15, 2015

IMHO this should be:

Of course, it should have been that. It will be corrected once my PR OCA/connector-magento#85 is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants