-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] budget by account #259
[ADD] budget by account #259
Conversation
5da331b
to
ac88904
Compare
aa22839
to
0348d06
Compare
0348d06
to
3dc7cb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional test ok
Merging into the 3.6 staging branch. People interested to test further can do so in #254 /ocabot merge Thanks for testing, @fclementic2c |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
Congratulations, your PR was merged at cb60ce5. Thanks a lot for contributing to OCA. ❤️ |
This introduces a new data source:
MIS Budget by Account
, next to the existingMIS Budget by KPI
.This essentially includes OCA/mis-builder-contrib#3 in
mis_builder_budget
with the subtle but important difference that budget items now cover a period instead of a single date. A pro-rata temporis adjustement is made on the budget items to correspond to the reporting periods.Common parts between MIS Budgets by KPI and Account are moved to abstract base classes.
This PR includes refactorings from [ ] #258. The last 3 commits are relevant here:
mis.budget.by.account
andmis.budget.by.account.item
models, and instroduce the abstract base classesprorata.read_group.mixin
model that does the pro-rata-temporis adjustments inread_group
and emulate a searchabledate
field based ondate_from
anddate_to
.I leave as a future improvement the capability to mix budgets by KPI and by account.