Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add to bot instructions through comments for maintaining migration issues #32

Closed
pedrobaeza opened this issue Dec 29, 2018 · 4 comments
Labels
Bot Task A task the bot does or should do enhancement New feature or request needs spec This issue is blocked due to lack of detailed specification

Comments

@pedrobaeza
Copy link
Member

A current problem is that migration issues with the list of modules to migrate is not up to date:

  • Already merged of migration PRs are not checked.
  • Or even worse, they are not noted.
  • New migration PRs are not in the list because they weren't in the repository in the previous version when the branches were created.

I think we can inspire in robodoo from Odoo for putting comments for doing certain automated tasks. A flow can be:

  • A PR for a migration is proposed.
  • A PSC put an instruction comment indicating the module and the version it migrates: @oca-git-bot migration 11.0 module_x.
  • The bot checks the migration issue (through the title "Migration to version X"), and fills the line with the author and the PR number, creating it if it doesn't exist.
  • When the PR is merged, then the bot marks the check.
  • If the PR is closed, the bot strikes-through the part of the text.
  • If a new PR for the same module appears (as superseeded), and a PSC instructs the bot with the same comment in the new PR, the text for the new one is added on the line.
@sbidoul sbidoul added enhancement New feature or request Bot Task A task the bot does or should do labels Dec 29, 2018
@emagdalenaC2i
Copy link

That flow will force all PSC to set that comments @OCA-git-bot migration 11.0 module_x
with the proper release and name of the module.
Also PSC should be notified or should check if there are new migration PRs

Instead of that workflow... We can search PR with the proper name (and force users to keep a specific formating name for their PRs): [Release] [MIG] Module_name
Like
[12.0] [MIG] hr_holidays_notify_employee_manager
So:

  • the bot search for new migration PR
  • The bot checks the migration issue (through the title "Migration to version X"), and fills the line with the author and the PR number, creating it if it doesn't exist.
  • When the PR is merged, then the bot marks the check.
  • If the PR is closed, the bot strikes-through the part of the text.
  • If a new PR for the same module appears the bot create a message in the new PR with a reference to the existing PR
  • If the old PR is closed (as superseeded) the bot strikes-through the part of the text and the text for the new PR is added on the line.

@pedrobaeza
Copy link
Member Author

pedrobaeza commented Dec 29, 2018

People is not going to use the correct syntax for the title, and it would be some kind of "black magic", so I prefer my approach. At the end, it takes the same time to set properly the title than to put that comment. What we don't want is that a non-PSC tricks the system for referencing incorrect things, so that's why I force that this should be done by a PSC.

@sbidoul sbidoul added the needs spec This issue is blocked due to lack of detailed specification label Jun 30, 2019
@legalsylvain
Copy link
Collaborator

If I understand correctly, this issue is fixed by #97

so can be closed ?

@pedrobaeza
Copy link
Member Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Task A task the bot does or should do enhancement New feature or request needs spec This issue is blocked due to lack of detailed specification
Projects
None yet
Development

No branches or pull requests

4 participants