XML record: Place id attribute before model

[voronind]

Odoo guidelines says that id attribute must be before model attribute for XML records.

Many OCA repos will be need to disable this checking or fix data files. In other case linter will fail.

[moylop260]

See the following output using Odoo v15.0:

rgrep "<record model=\".*\" id=\".*\"" odoo --include=*.xml |wc -l
1243

rgrep "<record model=\".*\" id=\".*\"" enterprise --include=*.xml |wc -l
386

What about creating a new generation of lints (new project) compatible with pre-commit in order to auto-fix XML?

e.g.

• https://github.com/lsst-ts/pre-commit-xmllint

[voronind]

And create 3rd project: pylint-odoo-project that will check respecting module dependencies.
In fact there is insufficient maintenance of one pylint-odoo project.

[moylop260]

Currently, the OCA is moving to auto-fix

In fact, you could do a small script to do it and only create the file hook for pre-commit in order to be auto-called from OCA pipelines and auto-fixed all the projects in one shot

It doesn't need to do a big project as pylint or sufficient maintenance

Check the following similar small project:

• https://github.com/lsst-ts/pre-commit-xmllint

It has only 2 commits and 3 files (README, pre-commit-hook, script)

Try to do proof of concept to create a script to get all the record nodes of a XML and change the id of position

and I can help you to adapt it to pre-commit

It could be better to auto-fix all them instead of mark it and fix manually

There are other kinds of lints that are not easy to auto-fix it or it is impossible to do it

But it is a good example to auto-fix it easy

[luisg123v]

Same for eval before name, e.g.:

<field eval="1" name="priority" />

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.