[16.0][FIX] fastapi: close cursor after rollback #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
changed the title
|
Hi @lmignon, |
This is to ensure that `retrying` in `service/model.py` does not try to flush.
lmignon
force-pushed
the
fastapi-close-cursor-on-error-sbi
branch
from
1a2a5cf
to
8be7fbb
Compare
lmignon
approved these changes
Dec 21, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a033014. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that
retryinginservice/model.pydoes not try to flush.https://github.com/odoo/odoo/blob/ab049b9a8e433c41028d3b6da94e4eca6fe2ea19/odoo/service/model.py#L134-L135