Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] sale_order_partner_restrict - Only allow to enter sales orders for companies or individual, not their associated contacts #1811

Closed
JordiBForgeFlow opened this issue Dec 7, 2021 · 10 comments
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@JordiBForgeFlow
Copy link
Sponsor Member

Currently you can create sales orders where the customer is a contact person, invoice address, etc.

However sometimes companies prefer to make sure that the order is only entered for the main company, in B2B, or the individual person in B2C.

The module 'sale_order_partner_restrict' would allow you to choose what level of restriction you'd like to apply when selecting from the list of customers.

This configuration would be available in Sales / Configuration / Settings, and the options available would be:

  • All partners (default)
  • Only parent accounts (no contacts)
  • Parent accounts and contact persons

cc @ForgeFlow

@pedrobaeza
Copy link
Member

Maybe this should be an extra option on the existing module: https://github.com/OCA/sale-workflow/tree/13.0/sale_partner_selectable_option

@JordiBForgeFlow
Copy link
Sponsor Member Author

@pedrobaeza good point

@HaraldPanten
Copy link
Contributor

HaraldPanten commented Dec 7, 2021

We've had similar requests from our customers. In POs too.

That should be restricted only for partner_id field. I'm not against Pedro's suggestion.

👍

@OriolVForgeFlow
Copy link

The existing module sale_partner_selectable_option doesn't make this option company dependent and the feature we want to add makes more sense if it does. We think that we should do a separate module to add that functionality as we are just adding a filter. What do you think?
@pedrobaeza @JordiMForgeFlow

@pedrobaeza
Copy link
Member

Are you going to share contacts across companies?

@pedrobaeza
Copy link
Member

Anyways, the extra option may work per company the same, through a field in res.company, but I don't want you to push to pack it in existing module. You can put another module for sure, and more if the scope starts to diverge too much.

@JordiMForgeFlow
Copy link
Contributor

The existing module sale_partner_selectable_option doesn't make this option company dependent and the feature we want to add makes more sense if it does. We think that we should do a separate module to add that functionality as we are just adding a filter. What do you think?
@pedrobaeza @JordiMForgeFlow

I agree, it would make more sense perhaps if the partner field was instead a property.

Nevertheless, it also seems to me that the sale_partner_selectable_option is more aimed at allowing manual flexibility on flagging the partners that should not be able to have orders, rather than to be used under a general setting.

@pedrobaeza
Copy link
Member

OK, so go ahead with your module to complement these options.

@OriolVForgeFlow
Copy link

Module "sale_order_partner_restrict" added! PR: #1826

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

5 participants