Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] connector_search_engine: Invalidate se_binding_ids on binding CRUD #163

Merged

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Oct 13, 2023

When bindings are created / updated / unlinked, we must invalidate the 'se_binding_ids' field of related records. In the case of an update, the invalidation is only done if the reference to the record changes

When bindings are created / updated / unlinked, we must invalidate the 'se_binding_ids' field of related records. In the case of an update, the invalidation is only done if the reference to the record changes
@lmignon lmignon force-pushed the 16.0-connector-search-engine-fix-se-binding-ids branch from 75a850a to 6f75a6b Compare October 13, 2023 09:32
@lmignon lmignon marked this pull request as ready for review October 13, 2023 09:33
Copy link
Contributor

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Oct 13, 2023

ping @qgroulard @rousseldenis

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Oct 13, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-163-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e56303c into OCA:16.0 Oct 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6249f22. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-connector-search-engine-fix-se-binding-ids branch October 13, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants