Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] connector_search_engine: export and delete on multi bindings #173

Merged
merged 1 commit into from Nov 29, 2023

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Nov 28, 2023

Fix error when calling the methods export_record or delete_record from
the se.binding model when called on a recordset with items from different
se.backend.

The export and delete methods involves the use of a Backend Adapter to
communicate with the target search engine. We then need to process the bindings
by backend to call the correct adapter and ensure at same time a batch process
of the requested operation for all the records linked to the same backend.

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Nov 28, 2023

cc @sebastienbeau @sbejaoui

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Nov 29, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not start, because command `git merge --no-ff -m 'Merge PR #173 into 16.0

Signed-off-by lmignon' tmp-pr-173` failed with output:

Auto-merging connector_search_engine/static/description/index.html
CONFLICT (content): Merge conflict in connector_search_engine/static/description/index.html
Auto-merging connector_search_engine/__manifest__.py
Auto-merging connector_search_engine/README.rst
CONFLICT (content): Merge conflict in connector_search_engine/README.rst
Automatic merge failed; fix conflicts and then commit the result.

Fix error when calling the methods *export_record* or *delete_record* from
the *se.binding* model when called on a recordset with items from different
*se.backend*.

The *export* and *delete* methods involves the use of a *Backend Adapter* to
communicate with the target search engine. We then need to process the bindings
by backend to call the correct adapter and ensure at same time a batch process
of the requested operation for all the records linked to the same backend.
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Nov 29, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-173-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3d2d076 into OCA:16.0 Nov 29, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d29f007. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-binding-recompute-multi branch November 29, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants