Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] connector_search_engine: No prefetch for binding data #179

Merged
merged 1 commit into from Dec 15, 2023
Merged

[16.0][IMP] connector_search_engine: No prefetch for binding data #179

merged 1 commit into from Dec 15, 2023

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Dec 12, 2023

No description provided.

@lmignon lmignon force-pushed the 16.0-binding-data-no-prefetch branch from 186919d to fc1b906 Compare December 12, 2023 16:01
@lmignon lmignon marked this pull request as ready for review December 12, 2023 16:01
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Dec 12, 2023

cc @sebastienbeau @sbejaoui @qgroulard

qgroulard
qgroulard approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Dec 14, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-179-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 14, 2023
@OCA-git-bot
Merge PR #179 into 16.0
79908f3 
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not start, because command `git merge --no-ff -m 'Merge PR #179 into 16.0

Signed-off-by lmignon' tmp-pr-179` failed with output:

Auto-merging connector_search_engine/static/description/index.html
CONFLICT (content): Merge conflict in connector_search_engine/static/description/index.html
Auto-merging connector_search_engine/models/se_binding.py
Auto-merging connector_search_engine/README.rst
CONFLICT (content): Merge conflict in connector_search_engine/README.rst
Automatic merge failed; fix conflicts and then commit the result.

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not be finalized, because command `git merge --no-ff -m 'Merge PR #179 into 16.0

Signed-off-by lmignon' tmp-pr-179` failed with output:

Auto-merging connector_search_engine/static/description/index.html
CONFLICT (content): Merge conflict in connector_search_engine/static/description/index.html
Auto-merging connector_search_engine/models/se_binding.py
Auto-merging connector_search_engine/README.rst
CONFLICT (content): Merge conflict in connector_search_engine/README.rst
Automatic merge failed; fix conflicts and then commit the result.

@lmignon
[IMP] connector_search_engine: No prefetch for binding data
df2d42b 
The field 'data' is a json field that is not used in the view or common management
operations of the binding model. This json field can be very large. By disabling
the prefetch, we avoid to overload the database and Odoo with useless data.
@lmignon lmignon force-pushed the 16.0-binding-data-no-prefetch branch from fc1b906 to df2d42b Compare December 15, 2023 07:13
@lmignon lmignon merged commit d6c553f into OCA:16.0 Dec 15, 2023
7 checks passed
@lmignon lmignon deleted the 16.0-binding-data-no-prefetch branch December 15, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qgroulard qgroulard qgroulard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lmignon @OCA-git-bot @qgroulard