Migration to version 13.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

• 13 - By @NL66278 - [13.0] [MIG] letsencrypt #1933
• auditlog - By @lembregtse - [WIP] [MIG] auditlog: Migration to 13.0 #1685 By @sebalix - [MIG] auditlog: Migration to 13.0 #1793
• auto_backup - By @jcarlosmontoya - 13.0 mig auto backup #1697
• base_cron_exclusion
• base_custom_info - By @dalonsod - [MIG] base_custom_info: Migration to 13.0 #1833
• base_exception - By @jaredkipe - [13.0][MIG] base_exception #1760 By @joao-p-marques - [13.0][MIG] base_exception: Migration to 13.0 #1920
• base_fontawesome
• base_import_odoo - By @hbrunn - [MIG] base_import_odoo: Migration to v13 #1948
• base_jsonify By @Laurent-Corron [13.0][MIG] base_jsonify #1704
• base_search_fuzzy
• base_technical_user
• base_view_inheritance_extension - By @sergio-teruel - [MIG][13.0] base_view_inheritance_extension: Migration to v13.0 #1779
• database_cleanup - By @newtratip - [13.0][MIG] database_cleanup #1745
• datetime_formatter - By @victoralmau - [13.0][MIG] datetime_formatter: Migration to 13.0 #2029
• dbfilter_from_header - By @newtratip - [MIG] dbfilter_from_header : Migration to 13.0 #1682
• excel_import_export - By @kittiu - [13.0][MIG] excel_import_export, excel_import_export_demo #1684
• excel_import_export_demo - By @kittiu - [13.0][MIG] excel_import_export, excel_import_export_demo #1684
• fetchmail_notify_error_to_sender
• html_image_url_extractor - By @victoralmau - [13.0][MIG] html_image_url_extractor: Migration to 13.0 #2030
• html_text - By @victoralmau - [13.0][MIG] html_text: Migration to 13.0 #2027
• module_analysis
• module_auto_update
• nsca_client - By @etobella - [MIG] nsca_client: Migration to 13.0 #2111
• onchange_helper
• scheduler_error_mailer - By @victoralmau - [13.0][MIG] scheduler_error_mailer: Migration to 13.0 #2260
• sentry
• sql_export
• sql_request_abstract

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[lembregtse]

Will be working on migration of auditlog (#1685)

[newtratip]

I'm working on dbfilter_from_header

[kittiu]

Work on excel_import_export and excel_import_export_demo

[schout-it]

working on module_auto_update

[gurneyalex]

anyone knows if onchange_helper still makes sense in 13.0 ? I guess yes because api.onchange is still around

[pedrobaeza]

Yes, it's needed as most code still uses it

[Laurent-Corron]

working on:

• base_jsonify [13.0][MIG] base_jsonify #1704
• onchange_helper [13.0][MIG] onchange_helper #1705

[ghost]

Can anyone work on base_exception ?

[LoisRForgeFlow]

base_cron_exclusion done in #1746.

[ghost]

base_custom_info don't get upgrade?

[AMhadhbi]

scheduler_error_mailer done in #1772.

[IvanShirokikh]

working on sentry #1776

[newtratip]

dbfilter_from_header #1781 supersedes #1682

[newtratip]

I'm working on html_text #1782

[ghost]

working in sql_request_abstract & sql_export #1783

[ghost]

hi,
after migrating sql_export ,I want to add live preview feature using pivot table widget.
anyone interested?

[codeagencybe]

@IvanShirokikh Is there any ETA when v13 for Sentry would be available?
Anything I can help with? beta test?

Thanks!

[luisg123v]

Hi,

It seems this list needs some updates:

• base_cron_exclusion: already done by @LoisRForgeFlow on [13.0][MIG] base_cron_exclusion #1746
• dbfilter_from_header: current PR superseded by [13.0][MIG] dbfilter_from_header #1781
• html_text: in progress by @newtratip on [13.0][MIG] html_text #1782
• onchange_helper: missing PR ([13.0][MIG] onchange_helper #1705)
• scheduler_error_mailer: in progress by @AMhadhbi on 13.0 mig scheduler error mailer #1772
• sentry: in progress by @IvanShirokikh on 13.0 mig sentry #1776
• sql_request_abstract: in progress by @Alfadil on 13.0 mig sql request abstract #1783

[luisg123v]

company_country done by @moylop260 on #1723

[yaazkal]

Hi, is there any ETA for dbfilter_from_header I see the PR is still open, maybe not ready yet?

[luisg123v]

@yaazkal maybe you should ask/offer help on the opened PR instead?

[newtratip]

Hi @yaazkal dbfilter_from_header is done now, Could you help to review ?

[IvanShirokikh]

@codeagencybe, Hi, PR on review, I don't know if it can be done faster

[yaazkal]

@luisg123v @newtratip thanks so much for your answers.

I'll test the PR and leave a comment there, forgive me the noise that I made here if that had corrupted this issue.

Have a nice day !

[okuryan]

@pedrobaeza ,we are working on migrating fetchmail_notify_error_to_sender

We have already migrated it. But problem we are having specifically with test_mail module.
In Odoo 12 we are inheriting tests from TestMailgateway class. See here https://github.com/OCA/server-tools/blob/12.0/fetchmail_notify_error_to_sender/tests/test_fetchmail_notify_error_to_sender.py#L10

In Odoo 11 we were inheriting tests from TestMail class. See here https://github.com/OCA/server-tools/blob/11.0/fetchmail_notify_error_to_sender/tests/test_fetchmail_notify_error_to_sender.py#L10

---

Now problem we are facing is that if we do like in Odoo 12 (inherit from TestMailgateway) standard Odoo tests are failing. For example this one on exactly this line https://github.com/odoo/odoo/blob/13.0/addons/test_mail/tests/test_mail_gateway.py#L335

Logically we thought - wow, we broken tests for emails. SO we run this test without our migrated module and EXACTLY this amount of tests also were failing. Be specifically the following test:

• test_message_process_alias_followers_bounce
• test_message_process_alias_followers_partners_bounce
• test_message_process_write_to_catchall
• test_message_process_alias_update

---

We tried to return back to old method like in Odoo 11 of inheriting from TestMail, and after some adjustments of course test is working.

But we have feeling that it is not right to inherit from TestMail as we are really making changes to gateway behavior. So inheriting from TestMailgateway sounds like proper way.

Has anybody faced same issues?

[pedrobaeza]

Sorry, I can't say as I don't know that one.

[okuryan]

@MiquelRForgeFlow I have seen you was working previously on another module fetchmail_incoming_log
Maybe you faced similar issues as I described above?

[MiquelRForgeFlow]

@okuryan I will check later, but your message above says about v12, not v13, or is it an error?

[okuryan]

@MiquelRForgeFlow in message above I'm saying that when I run standard Odoo 13 tests from test_mail - they fail.
While in Odoo 12 same tests worked.

So I'm wondering either problem is really with Odoo 13 Standard having not working tests. Or we are writing/running tests incorrectly for Odoo 13 mail functionality testing.

[okuryan]

@MiquelRForgeFlow , could you, please, do code review from your side of this pull request?
#1815

I think on OCA infrastructure we do not have issues with tests described above.

@pedrobaeza , you are also welcome to participate in code review :)

[MiquelRForgeFlow]

@okuryan fetchmail_incoming_log done in #1820 😉

[okuryan]

@MiquelRForgeFlow nice, see it is already approved! =) And also our fetchmail_notify_error_to_sender merge request already reviewed and ready to be merged. #1815

[captivea-dcr]

sql_export #1858

[joao-p-marques]

I will migrate base_exception #1920 (superseeds #1760)

[alessandro-fiorino]

I'm working on excel_import_export

[phuctranfxvn]

configuration_helper migrated #1925

[santostelmo]

I'm working on module_analysis #1981

[victoralmau]

I'm working on html_text #2027

[victoralmau]

I'm working on html_image_url_extractor #2030

[victoralmau]

I'm working on datetime_formatter #2029

[unique4]

Could anyone add iap_alternative_provider to to migration list?

[randall-vx]

I'm working on attachment_unindex_content #2129

[NL66278]

letsencrypt module is not in list, but migration PR is here: #1933