[FIX] fs_image: remove rawCacheKey invalidation #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
sbejaoui
force-pushed
the
16.0-fs_image-sbj
branch
from
29eb343
to
1a71cf7
Compare
sbejaoui
changed the title
|
@sbejaoui can you add a fragment to include into the addon history... as it's done here https://github.com/OCA/storage/pull/304/files#diff-0c0256bf7a5f02140833fcc325442a42553aac6aaf8b013258f347d6ce2d7e8c |
lmignon
reviewed
Nov 30, 2023
sbejaoui
force-pushed
the
16.0-fs_image-sbj
branch
2 times, most recently
from
0f57a90
to
7b3d5b6
Compare
done |
lmignon
requested changes
Dec 2, 2023
rawCacheKey is properly managed by STD
sbejaoui
force-pushed
the
16.0-fs_image-sbj
branch
from
7b3d5b6
to
50bb88e
Compare
lmignon
approved these changes
Dec 2, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at bccc50c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix view crash when uploading an image
The rawCacheKey is appropriately managed by the base class and reflects the
record's last update datetime (write_date).
Since it lacks a setter, attempting to invalidate its value results in a view crash.
Nevertheless, the value will automatically be updated upon saving the record.