Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When directory_path is set the wrong protocol is used #311

Closed
simahawk opened this issue Dec 12, 2023 · 1 comment
Closed

When directory_path is set the wrong protocol is used #311

simahawk opened this issue Dec 12, 2023 · 1 comment
Labels
bug Something isn't working stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@simahawk
Copy link
Contributor

simahawk commented Dec 12, 2023

If you set directory_path while using SFTP for instance, the fs object won't be the one of the protocol you've chosen.
In storage_backend you can set a default root path for all type of storages.

It will automatically - and w/o notice - use RootedDirFileSystem. This leads to broken implementations because it will raise NotImplementedError when trying to use sftp api.

It would be nice to support this in the future. Meanwhile we should probably ignore that param and/or hide it or raise warning.

To reproduce:

  1. add an sftp storage
  2. set a directory_path
  3. try to move a file
  4. kaboom
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant