Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] web_responsive: odoo.define_section is undefined #759

Closed
yajo opened this issue Oct 17, 2017 · 4 comments
Closed

[11.0] web_responsive: odoo.define_section is undefined #759

yajo opened this issue Oct 17, 2017 · 4 comments

Comments

@yajo
Copy link
Member

yajo commented Oct 17, 2017

Current 11.0 builds will all fail due to:

odoo.define_section('web_responsive', ['web_responsive'], function(test) {

Odoo 11.0 changed the way we write widget tests, and in this change, it removed odoo.define_section. That's why we are getting errors such as this one:

` AssertionError: ("TypeError: undefined is not a function (evaluating 'odoo.define_section')\n"
`  ' at http://127.0.0.1:8069/web_responsive/static/tests/js/web_responsive.js:4 '
`  '(in global code)\n'
`  '(leaf frame on top)')

We have to fix that, and it would be good to add the instructions to https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 once discovered how to do it.

The good news is that we have lots of good examples available and some introduction in slides 35-41 of @gde-odoo's presentation at Odoo Experience 2017.

To start, it seems you have to just use odoo.define to run the tests, but I'm not sure the depth of the changes in that file to adapt to new tests, to be honest...

cc @Tecnativa @lasley @angelmoya

@lasley
Copy link
Contributor

lasley commented Oct 17, 2017

Yay... another completely undocumented tour system to learn. Thanks Odoo

@pedrobaeza
Copy link
Member

Well, as stated in Odoo days, they're working on that part now.

@yajo
Copy link
Member Author

yajo commented Oct 18, 2017

Yes, at least you can check the JS code and it should contain proper docstrings right now, although you still have to guess the right file to look up to. 😆

@hgminh95
Copy link
Contributor

Since this module does not use Odoo Widget, there are only some changes in syntax of javascript test. I have provided a fix. You guys can take a look at #772.

@yajo yajo closed this as completed in #772 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants