Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] Base modules #111

Merged
merged 69 commits into from Oct 30, 2020
Merged

[13.0][MIG] Base modules #111

merged 69 commits into from Oct 30, 2020

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Apr 19, 2020

TODO:

  • use odoo-test-helper in cms_info too
  • replace changelog w/ towcrier
  • review delete content JS and test in UI
  • test website module request mock utils

simahawk and others added 30 commits April 18, 2020 16:16
* [add] status message: javascript rendering

* [imp] status message js: reuse existing qweb templates
1. load qweb template on demand
2. load qweb template only if not loaded yet
3. use promises for rendering

We load qweb templates via JS. Prior to this change we got 1 request every time,
on every page load, even if we were not using any status message feature.

Now we load templates only when needed and we load it only if not loaded yet,
lowering page load time a bit :)

Plus, rendering now returns a promise object so you can chain calls
and do things when rendering is really finished.
The example package was there only to show how a message would look like.
But in real life you want always to verify how they look like
with your theme styles applied.

Now we have a new route `/cms/status-message/display-test` to check them.
`cms_status_message_example` module has been removed.
@simahawk simahawk changed the title [13.0][MIG] Base modules [13.0][MIG] Base modules [WIP] Apr 19, 2020
@simahawk simahawk added this to the 13.0 milestone Apr 19, 2020
@simahawk simahawk changed the title [13.0][MIG] Base modules [WIP] [13.0][MIG] Base modules Oct 27, 2020
@simahawk simahawk merged commit ca29216 into OCA:13.0 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants