-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] website_js_below_the_fold: odoo.define is not a function on /payment/process #587
Comments
I have the same issue which cause payment/process stuck and no jump to confirmation page. |
Why no one pay attention to this issue? the module is good in speed performance but it cause payment issues. I can reproduce it in the odoo runbot. So it is definitely an bug. Is there anyway not put the js below the fold on payment page? |
@tarteo Could you have look into the issue please. Thank you |
Yes, I can confirm this issue. |
@frankmiao2015
This is a community where nobody is obligated to work on something... |
@tarteo First of all thanks for sharing your hard work with the community. Yes, we should try to solve things by over own first. A way to learn... but you know common problems with the newbies like me... @mgielissen @frankmiao2015 I would like to share a workaround... I have successfuly tested it. But please do your testing and let me know if you find any issues. Now the workaround for the payment process page! To achieve this, please add below code in your theme or any custom module.
|
@tarteo First, I should say sorry to disturb you by the @ action and this time again. But I did not mean that you are obligated on the thing. I was just trying to draw your attention in case you did not aware of the issue. As for the fix, honestly speaking, I barely have no knowledge on js. I am new to coding as well as github. I simply tried the @function by the author key word and in luck found you. I will not be so rude anymore in the future to @ someone who is not care for sure. Anyway, Thanks for your contribution. @go4site I applied your fix on my theme template. It works for all payments now. Thank you very much! |
You are welcome @frankmiao2015 . Happy to help! |
@go4site , I confirm that your patch s working. |
meanwhile, don't you think so it would be great to add this as known issue in the module readme? |
@flotho @bizzappdev I hope Tarteo reads it and adds my code in the module or at least adds this as known issue in the module readme. |
Yeap, just found the same issue.. I've created this PR to fix it: #736 |
So, this issue can be closed? |
Yes it can! |
On a fresh database with these modules installed: The event registration button is not working for public user. (But it works when logged in as a standard user) |
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
When processing a payment in the webshop, /payment/process gives an error in webconsole:
process:298 Uncaught TypeError: odoo.define is not a function
<script> odoo.define('payment.processing_bootstrap', function(require) { ...</script>at process:298
The text was updated successfully, but these errors were encountered: