Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixture E003_E034_empty should be E063 #52

Closed
pwinckles opened this issue Mar 29, 2021 · 3 comments · Fixed by #58
Closed

fixture E003_E034_empty should be E063 #52

pwinckles opened this issue Mar 29, 2021 · 3 comments · Fixed by #58

Comments

@pwinckles
Copy link
Contributor

Fixture E003_E034_empty, an empty directory, say that it should fail with E034, but I think E063 makes more sense.

E034: An OCFL Object Inventory must follow the [JSON] structure described in this section and MUST be named inventory.json

E063: Every OCFL Object must have an inventory file within the OCFL Object Root, corresponding to the state of the OCFL Object at the current version.
@pwinckles
Copy link
Contributor Author

Same problem with fixture E034_no_inv

@zimeon
Copy link
Collaborator

zimeon commented Mar 30, 2021

Yes, I agree that E063 is a better error for a missing root inventory.

Can you think of any fixture that would generate an E034 -- I can't imagine writing validator code that looked for an inventory file with a different name so I don't think this code would ever generated

@pwinckles
Copy link
Contributor Author

No, my code will currently never generate E034.

This was referenced Mar 30, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename to suggest E063 instead of E034 OCFL/fixtures
2 participants
@zimeon @pwinckles