Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker containers install only one python module #36

Closed
kba opened this issue Jan 8, 2020 · 7 comments · Fixed by #38
Closed

Docker containers install only one python module #36

kba opened this issue Jan 8, 2020 · 7 comments · Fixed by #38
Labels
bug Something isn't working

Comments

@kba
Copy link
Member

kba commented Jan 8, 2020

Pretty bizarre behavior, we have an error in our setup somewhere. Apparently only one python module per docker image is installed. This only concerns python modules, projects like im6convert, olena and tesseract are installed fine.

In minimum, only ocrd_tesserocr is installed.

In medium, only cor-asv-ann is installed.

In maximum, only ocrd_kraken (of all modules) is installed.

@kba kba added the bug Something isn't working label Jan 8, 2020
@kba
Copy link
Member Author

kba commented Jan 8, 2020

Same problem for the -git variants.

OCRD_MODULES is correctly set though, e.g. in minimum:

echo $OCRD_MODULES
core ocrd_im6convert ocrd_cis ocrd_tesserocr tesserocr workflow-configuration ocrd_repair_inconsistencies

@bertsky
Copy link
Collaborator

bertsky commented Jan 8, 2020

I believe my new multirule is the culprit. Still investigating...

@kba
Copy link
Member Author

kba commented Jan 8, 2020

In the -git variant, I can run the docker.sh script manually and it will also only install ocrd and one other python module so at least it's consistent.

@bertsky
Copy link
Collaborator

bertsky commented Jan 8, 2020

I believe my new multirule is the culprit. Still investigating...

Confirmed. The problem is that the executables from all modules are put into one pseudo-pattern rule, where it should be one for each module. Sorry!

I am working at a solution. But suggestions welcome.

@kba
Copy link
Member Author

kba commented Jan 8, 2020

But suggestions welcome.

As a quick fix: Revert f8af582 ?

@bertsky
Copy link
Collaborator

bertsky commented Jan 8, 2020

As a quick fix: Revert f8af582 ?

Yes, but that will slow down build extremely again.

Another option would be to give up the common build rule: move the existing recipe into a canned recipe, and add a (still multirule based) build rule using that to each module section.

@bertsky
Copy link
Collaborator

bertsky commented Jan 8, 2020

Another option would be to give up the common build rule: move the existing recipe into a canned recipe, and add a (still multirule based) build rule using that to each module section.

#38 is an attempt at that. Still testing locally, but we should already test the remote (CI/DH) side as well.

@kba kba closed this as completed in #38 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants