Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Packages are not built properly. #528

Closed
robertmclaws opened this issue Sep 27, 2016 · 2 comments
Closed

NuGet Packages are not built properly. #528

robertmclaws opened this issue Sep 27, 2016 · 2 comments

Comments

@robertmclaws
Copy link
Collaborator

Problem

The NuGet packages are built using the "pack" command against the .csproj files themselves, resulting in the most bare-bones possible package file. These package files do not contain any information about Restier as a product, nor do they contain the source files to make debugging issues easier.

Solution

Each assembly needs a proper .nuspec file so that more details about the product can be added, like decsriptions, tags, and the like. These new .nuspec files also need to be modified to contain the source files, so that .symbols.nuspec files can be automatically generated and submitted to NuGet.

@chinadragon0515
Copy link
Contributor

Can I know what's the information are missed? We use Nuget package explorer to validate the package before we deliver, We do build package based on nuspec.
image

For the source code, I do not think it is a good practice to make it part of product dll. We upload symbols file to https://nuget.smbsrc.net which is the new location for nuget package source files.

@robertmclaws
Copy link
Collaborator Author

I've actually partially fixed this issue in PR #560. I updated the batch file that builds the NuGet packages to let you pass in the version number into the command, as well as automatically build the Symbol packages too. The "push" command will automatically push the Symbols packages to the right place for it to work during debugging.

Since the projects now have NuSpec files, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants