Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data for Invoice order partial #1121

Open
dathwa opened this issue May 2, 2024 · 1 comment
Open

Missing data for Invoice order partial #1121

dathwa opened this issue May 2, 2024 · 1 comment

Comments

@dathwa
Copy link

dathwa commented May 2, 2024

Hello.
Mall 3.2.1
Using the partial from mall theme taxes.htm
Prevoiusly, entry.tax.name, entry.tax.percentage and entry.total_formatted were all available.
Now i am missing entry.tax.name (as well as a few other unused vars).
Is this normal?
Thank-you.

Examples
Custom Method (before)

"taxes" => array:1 [▼
    0 => array:5 [▼
      "tax" => array:8 [▼
        "id" => 1
        "name" => "UK VAT"
        "percentage" => "20.00"
        "created_at" => "2020-01-29T14:26:02.000000Z"
        "updated_at" => "2020-02-26T15:12:18.000000Z"
        "is_default" => true
        "pivot" => array:2 [▶]
        "countries" => []
      ]
      "amount" => 4167
      "total" => 833
      "amount_formatted" => "£ 41.67"
      "total_formatted" => "£ 8.33"
    ]
Stripe (after)
 "taxes" => array:1 [▼
    0 => array:5 [▼
      "tax" => array:1 [▼
        "percentage" => "20.00"
      ]
      "amount" => 833
      "total" => 167
      "amount_formatted" => "£ 8.33"
      "total_formatted" => "£ 1.67"
    ]
  ]
@SamBrishes
Copy link
Collaborator

Hello,

Unfortunately, the detailed data about the used tax is not passed to the PriceBag construct, which is used for the TotalsCalculator class. I'm currently improving the PriceBag handling anyway and will pass the missing data to fix this issue.

Sincerely,
Sam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants