Recent update broke lazyloading

[PubliAlex]

Hello,

Due to a recent plugin update (don't know the exact commit), the lazyloading on image no longer work.

I used to use the excellent lazysizes library in order to manage lazyloading for my images, which lead to something like that :

<img class="lazyload" data-src="{{ 'assets/img/mypicture.jpg'|theme }}" data-sizes="auto" alt="" />

And until now, it worked perfectly, when the image come to the viewport, lazysizes do it's stuff and dynamically add the src tag to my image. I developped more than 50 website that way, without problems.

I noticed recently on some website that lazyloading was broken, all pictures on the pages directly have a src tag, even if not on the viewport.

I could confirm that the problem is due to an update of this plugin. I tested on an old install (before focus update), the lazyloading worked perfectly. Then, I updated the module, and the src tag of all images were here on page load :/

Not a critical issue cause it does not break websites, but lazyloading is an important thing today, so It's a quite major issue as many live website that use this module probably lost lazyloading features.

Best regards,

Alex

[PubliAlex]

Found the concerned issue. It seems to be the one of April 29th #35

Especially that line : $this->setSrcAttribute($node, $sourceSet);