Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some MassBalanceModels rely on t_star if no y0 is provided #1447

Closed
pat-schmitt opened this issue Jul 20, 2022 · 1 comment · Fixed by #1464
Closed

Some MassBalanceModels rely on t_star if no y0 is provided #1447

pat-schmitt opened this issue Jul 20, 2022 · 1 comment · Fixed by #1464
Assignees

Comments

@pat-schmitt
Copy link
Member

Some MassBalanceModels rely on the year of t_star if no y0 is provided (see here, here, here and here), but with the new glacier by glacier calibration to geodetic measurements t_star is set to None (e.g. here).
This could lead to 'hard-to-interpret' errors if someone tries out some of the tutorials, starting from prepro gdirs which use this glacier by glacier calibration.

So maybe we should think of a new default if no y0 is provided to the MassBalanceModels (e.g. y0 = gdir.rgi_date + 1).

@fmaussion
Copy link
Member

I would be in favor of raising a meningful error and force users to set y0 explicitely

Explicit is better than implicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants