Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy Snapshot resizes images in VTK and they doesn't fit the viewport #1168

Closed
mirnasilva opened this issue Nov 12, 2019 · 2 comments
Closed
Assignees

Comments

@mirnasilva
Copy link
Contributor

Bug Report

Describe the Bug

Due to Percy snapshot, the images inside the viewports are being resized (in VTK) and once the browser continues the test automation execution, the images are not centered in the viewport.
To fix that, we need to reload the page before each test in cypress.

This issue is only reproducible on the test automation execution.

Steps to Reproduce

  1. To reproduce the issue on test automation, go to file: platform/viewer/cypress/integration/pwa/OHIFExtensionVTK.spec.js
  2. Replace the functions before() and beforeEach() by the following code:
before(() => {
    cy.openStudy('Juno');
    cy.waitDicomImage();
    cy.expectMinimumThumbnails(7);

    //Waiting for the desired thumbnail content to be displayed
    cy.get('[data-cy="thumbnail-list"]').should($list => {
      expect($list).to.contain('CT WB 5.0  B35f');
    });

    //drag thumbnail
    cy.get('[data-cy="thumbnail-list"]')
      .contains('CT WB 5.0  B35f')
      .drag('.viewport-drop-target')
      .wait(1000);

    //Select 2D MPR button
    cy.get('.PluginSwitch > .toolbar-button').click();

    //Wait Reformatting Images
    cy.waitVTKReformatting();
  });

  beforeEach(() => {
    cy.initVTKToolsAliases();
  });
@mirnasilva
Copy link
Contributor Author

I tried to reproduce the issue again without reloading the page and I was not able to see it happening.
I think it worth the investigation just to be sure if it is really happening or not.

@dannyrb
Copy link
Member

dannyrb commented Nov 19, 2019

I'm unable to reproduce. If someone else reports, more than happy to reopen this issue.

@dannyrb dannyrb closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants