Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private tags rending in the image as junk data #2688

Closed
xtfer opened this issue Jan 25, 2022 · 1 comment
Closed

Private tags rending in the image as junk data #2688

xtfer opened this issue Jan 25, 2022 · 1 comment

Comments

@xtfer
Copy link

xtfer commented Jan 25, 2022

Bug Report

Tested in viewer 4.12.12.

Describe the Bug

Images with private tags attempt to render the private tags as image data. This also causes the pixel data to be offset.

What steps can we follow to reproduce the bug?

Tested with both MR images with private Siemens CSA tags and sample CT scan with private header

Possibly related to cornerstonejs/dicomParser#114, though that appears to be already fixed and committed since dicom-parser 1.8.5.

Example showing how this looks when rendering

CleanShot 2022-01-28 at 10 40 13@2x

@xtfer xtfer changed the title MR images with Siemens CSA tags produce garbage output Private tags rending in the image as junk data Jan 27, 2022
@xtfer
Copy link
Author

xtfer commented Jan 29, 2022

For anyone who finds this later, the issue was in fact that our DICOM endpoint was returning 'Content-Type: application/dicom` when OHIF was requesting 'Content-Type: application/octet-stream'.

@xtfer xtfer closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant