Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugs): fix patient header for doc, track ball rotate resize observer and add segmentation button not being enabled on viewport data change #4068

Merged
merged 1 commit into from Apr 28, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

Fix 3 bugs:

  • Trackball rotate resize observer throwing error on undefined elements
  • Patient info header showing multiple patients when it was not supposed to
  • Add segmentation button stays grayed out if there was a non-reconstructable displayset in the viewport, and a reconstructable one gets dropped in

@IbrahimCSAE IbrahimCSAE requested a review from sedghi April 26, 2024 17:23
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 2f4df96
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/662be2f6ca8758000879cfad
😎 Deploy Preview https://deploy-preview-4068--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 2f4df96
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/662be2f6225454000823deda
😎 Deploy Preview https://deploy-preview-4068--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (b4ed80d) to head (2f4df96).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4068       +/-   ##
===========================================
+ Coverage        0   44.41%   +44.41%     
===========================================
  Files           0       80       +80     
  Lines           0     1333     +1333     
  Branches        0      327      +327     
===========================================
+ Hits            0      592      +592     
- Misses          0      588      +588     
- Partials        0      153      +153     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 26, 2024

1 failed test on run #3870 ↗︎

1 42 0 0 Flakiness 0

Details:

bug fixes
Project: Viewers Commit: 2f4df9673e
Status: Failed Duration: 06:16 💡
Started: Apr 26, 2024 5:33 PM Ended: Apr 26, 2024 5:39 PM
Failed  cypress/integration/study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > maintains Description filter upon return from viewer Test Replay Screenshots Video

Review all test suite changes for PR #4068 ↗︎

@sedghi sedghi merged commit c09311d into master Apr 28, 2024
8 of 10 checks passed
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 30, 2024
…ver and add segmentation button not being enabled on viewport data change (OHIF#4068)
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
…ver and add segmentation button not being enabled on viewport data change (OHIF#4068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants