Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Overlay fails on viewports when used with hanging protocols #4168

Open
haldawe2 opened this issue May 24, 2024 · 2 comments
Open

[Bug] Overlay fails on viewports when used with hanging protocols #4168

haldawe2 opened this issue May 24, 2024 · 2 comments
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@haldawe2
Copy link

Describe the Bug

When using hanging protocols, and going into a study from the study browser or from a direct link, sometimes some or all of the overlays fail to render with a console error. Refreshing the page or going from one stage to another seems to work fine all the time.

image

image

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
at http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1998:29
at Array.forEach ()
at clearUntouched (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1995:85)
at draw (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1100:22)
at AnnotationRenderingEngine._triggerRender (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44785:58)
at AnnotationRenderingEngine._renderFlaggedViewports (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44713:26)

Steps to Reproduce

  1. Get this DX in a server. DX.zip
  2. Open the study with at least 1x2 HP (&hangingProtocolId=@ohif/mnGrid) from the study browser or using a direct link in a new tab

The current behavior

Sometimes the overlay fails to render

The expected behavior

Always renders the overlay

OS

Windows 10

Node version

20.11.1

Browser

Chrome 125.0.6422.77

@haldawe2 haldawe2 added the Awaiting Reproduction Can we reproduce the reported bug? label May 24, 2024
@sedghi
Copy link
Member

sedghi commented May 24, 2024

Thanks, we will look

@wayfarer3130
Copy link
Contributor

Fixed in #4224

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Awaiting Reproduction Can we reproduce the reported bug? labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

3 participants