Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(measurements): Show missing measurements in measurement table #426

Merged
merged 1 commit into from
May 13, 2019

Conversation

evren217
Copy link
Member

  • Bump cornerstone-tools to 3.9.0, ohif-core to 0.5.2 and react-viewerbase to 0.4.1
  • Add bidirectional, elliptical, circle and rectangle roi tools
  • Support labeling and context-menu for all annotation tools
  • Sort measurements by lesion naming number to show the last added measurement in the end in measurement table

- Bump cornerstone-tools to 3.9.0, ohif-core to 0.5.2 and react-viewerbase to 0.4.1
- Add bidirectional, elliptical, circle and rectangle roi tools
- Support labeling and context-menu for all annotation tools
- Sort measurements by lesion naming number to show the last added measurement in the end in measurement table
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #426 into react will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           react    #426      +/-   ##
========================================
- Coverage   1.07%   1.07%   -0.01%     
========================================
  Files         62      62              
  Lines       1206    1209       +3     
  Branches     135     135              
========================================
  Hits          13      13              
- Misses      1060    1063       +3     
  Partials     133     133
Impacted Files Coverage Δ
src/utils/getDefaultToolbarButtons.js 100% <ø> (ø) ⬆️
src/setupTools.js 0% <ø> (ø) ⬆️
src/connectedComponents/ToolContextMenu.js 0% <0%> (ø) ⬆️
...c/connectedComponents/ConnectedMeasurementTable.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12172ea...9bacf43. Read the comment docs.

@evren217 evren217 merged commit 065a81d into react May 13, 2019
@evren217 evren217 deleted the fix-measurements branch May 13, 2019 22:08
@ohif-bot
Copy link
Member

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants