New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[内容有误] 线性筛注释与代码需改正 #4535

Closed

1 task

cubeheadsun opened this issue Dec 25, 2022 · 2 comments · Fixed by #4538

Closed

1 task

[内容有误] 线性筛注释与代码需改正 #4535

cubeheadsun opened this issue Dec 25, 2022 · 2 comments · Fixed by #4538

Labels

Content Bug / 页面内容有误 help wanted / 需要帮助

Contributor

cubeheadsun commented Dec 25, 2022 •

edited

请选择：

我正在着手修复这个问题

我正在访问这个页面

https://oiwiki.vx.st/math/number-theory/sieve/

我发现页面有这样的问题

线性筛有点问题，第一是注释，第二是代码。

因为在文章中，并没有说要筛出小于MAXN的个数，反而在前面说过是1-n，所以应该改成`<=MAXN`才对，并且应该把 `if (1ll * i * pri[j] >= MAXN) break;`改成`if (1ll * i * pri[j] > MAXN) break;`

除了这点之外，注释的描述也又问题，应把`由于 pri 里面质数是从小到大的，所以 i 乘上其他的质数的结果一定也是 pri[j] 的倍数它们都被筛过了，就不需要再筛了，所以这里直接 break掉就可以了`改为`由于 pri里面质数是从小到大的，所以 i 乘上其他的质数的结果一定会被 pri[j]的倍数筛掉，就不需要在这里先筛一次，所以这里直接 break 掉就好了`

The text was updated successfully, but these errors were encountered:

cubeheadsun added Content Bug / 页面内容有误 help wanted / 需要帮助 labels

welcome bot commented Dec 25, 2022

感谢你对 OI Wiki 的关注！记得在 Issue 中表达清楚自己的意思哦～

Contributor Author

cubeheadsun commented Dec 25, 2022

我~~也不太确定~~我说的对不对，我太菜了QWQ

Tiphereth-A mentioned this issue

fix(sieve.md):修改线性筛注释的歧义以及一些小补充 #4538

Merged

1 task

Tiphereth-A closed this as completed in #4538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment