Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failed #11

Open
kodein1 opened this issue Oct 18, 2023 · 19 comments
Open

Installation failed #11

kodein1 opened this issue Oct 18, 2023 · 19 comments

Comments

@kodein1
Copy link

kodein1 commented Oct 18, 2023

Installation failed

@OIakera
Copy link
Owner

OIakera commented Oct 18, 2023

Share magisk log?

@kodein1
Copy link
Author

kodein1 commented Oct 18, 2023 via email

@theduffster
Copy link

theduffster commented Oct 25, 2023

I have the same issue, the log is below. V5 installs successfully, just not V6.

I also have a question, when you say "Need Kernel Support" do you mean this needs some kernel flags you would only find in a custom kernel, or would it be supported by some stock kernels?

Thank you again for your work! Can't believe this doesn't have more exposure with how crazy the audiophile community is. I'm also wondering, do you have any further insight on what this actually does? I can't find any documentation on it anywhere, especially since the original XDA thread got taken off the internet.

- Copying zip to temp directory
- Installing high_perf_dac-v6.zip
- Current boot slot: _b
- Device is system-as-root
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: module.prop
****************
 High perf DAC 
 by reallyakera 
****************
*******************
 Powered by Magisk 
*******************
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: customize.sh
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: LICENSE
  inflating: README.md
  inflating: customize.sh
  inflating: module.prop
  inflating: service.sh
- Extracting module files
/data/user/0/sq.dm.fu.ge.d/cache/flash/update-binary: /data/adb/modules_update/high_perf_dac/customize.sh: line 16: syntax error: unexpected "(" (expecting word)
! Installation failed

@OIakera
Copy link
Owner

OIakera commented Oct 25, 2023

Yes Need Kernel Support buzzcut-s/kernel_msm8996@984a263

Every phone powered by a Qualcomm processor has a built-in WCD9xx Audio DAC, but it's rarely configured to be used to its full potential by OEMs. ... By enabling High-Performance Mode, the audio quality of Qualcomm-powered devices will not only receive a boost in volume but will sound more clear and crisp as well.

@theduffster
Copy link

theduffster commented Oct 25, 2023

Thank you for the response! Hmmm, wonder how it works internally. Maybe it increase the amplifier gain? Not sure that would necessarily improve sound quality though.

Looking at the source code, the description is "enable/disable class AB config for hph". Definitely doesn't reveal much, so mysterious...

It looks like high performance mode enables these parameters:

WCD9XXX_CLSH_STATE_HPHR,
WCD9XXX_CLSH_REQ_ENABLE,
WCD9XXX_CLSH_EVENT_PRE_DAC)

I'm also not sure this is even possible on newer phones, looking through newer phone source code I have yet to see "high_perf_mode" as an option in WCD9335+ phones. Still, Qualcomm says on their own website "High Performance Audio Playback" exists all the way up to the 9385.

@theduffster
Copy link

@OIakera do you know if anyone has gotten this to work with a newer SOC like the 8 Gen 1?

@OIakera
Copy link
Owner

OIakera commented Oct 26, 2023

Nope I don't have tester and I'm using SD870.

@theduffster
Copy link

theduffster commented Oct 27, 2023

Thanks again for the reply, that's very helpful. The 870 has the newest DAC Qualcomm makes, the WCD9385, too bad you don't have a way to test it.

@FunkyNico
Copy link

Hey there, i have the same issue but i'm using KSU i have a Joyeuse (miatoll) with a Qualcomm Snapdragon 720G, for what i read should have an internal WCD9385 DAC if i flash the v5.5 works ok, but with v6 the script doesn't install.

I attached the log.
KernelSU_install_log_2023-10-28-18-53-17.log

Thanks.

@OIakera
Copy link
Owner

OIakera commented Oct 28, 2023

Hey there, i have the same issue but i'm using KSU i have a Joyeuse (miatoll) with a Qualcomm Snapdragon 720G, for what i read should have an internal WCD9385 DAC if i flash the v5.5 works ok, but with v6 the script doesn't install.

I attached the log. KernelSU_install_log_2023-10-28-18-53-17.log

Thanks.

Try this
high_perf_dac-master.zip

@FunkyNico
Copy link

Hey there, i have the same issue but i'm using KSU i have a Joyeuse (miatoll) with a Qualcomm Snapdragon 720G, for what i read should have an internal WCD9385 DAC if i flash the v5.5 works ok, but with v6 the script doesn't install.
I attached the log. KernelSU_install_log_2023-10-28-18-53-17.log
Thanks.

Try this high_perf_dac-master.zip

It worked, flashed correctly.

@OIakera
Copy link
Owner

OIakera commented Oct 28, 2023

Nice 👍

@theduffster
Copy link

theduffster commented Oct 29, 2023

Flashed correctly for me too, rightfully tells me my kernel isn't supported. Thank you!

@FunkyNico does it work with your kernel? What kernel are you using?

My log in case anyone wants to see it:

- Copying zip to temp directory
- Installing high_perf_dac-master.zip
- Current boot slot: _b
- Device is system-as-root
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: module.prop
****************
 High perf DAC 
 by reallyakera 
****************
*******************
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: customize.sh
 Powered by Magisk 
*******************
- Extracting module files
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: LICENSE
  inflating: README.md
  inflating: customize.sh
  inflating: module.prop
  inflating: service.sh
+ print
+ ui_print 
+ true
+ echo 
+ ui_print '• Device : XQ-CQ62'
+ true
+ echo '• Device : XQ-CQ62'
+ ui_print '• Android : 13'
+ true
+ echo '• Android : 13'
+ ui_print '• Hardware : qcom'
+ true
+ echo '• Hardware : qcom'
+ ui_print 
+ true
+ echo 
+ extract
+ ui_print '- Extracting module files'
+ true
+ echo '- Extracting module files'
+ unzip -o /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip module.prop -d /data/adb/modules_update/high_perf_dac
- Done

• Device : XQ-CQ62
• Android : 13
• Hardware : qcom

- Extracting module files
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: module.prop
+ unzip -o /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip service.sh -d /data/adb/modules_update/high_perf_dac
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: service.sh
+ ui_print '• Codename : '
+ true
+ echo '• Codename : '
+ detect
+ '[' qcom '==' qcom ]
+ ui_print 
+ true
+ echo 
+ ui_print '• ✓ Qcom Detected'
+ true
+ echo '• ✓ Qcom Detected'
+ ui_print 
+ true
+ echo 
+ '[' 
sh: missing ]
+ ui_print 
+ true
+ echo 
+ ui_print '- ! Failed because your Kernel is Not Supported'
+ true
+ echo '- ! Failed because your Kernel is Not Supported'
+ ui_print 
+ true
+ echo 
+ abort
+ ui_print 
+ true
+ echo 
+ true
+ '[' '!' -z /data/adb/modules_update/high_perf_dac ]
+ rm -rf /data/adb/modules_update/high_perf_dac
+ rm -rf /dev/tmp
+ exit 1
• Codename : 

• ✓ Qcom Detected


- ! Failed because your Kernel is Not Supported


! Installation failed

@FunkyNico
Copy link

Flashed correctly for me too, rightfully tells me my kernel isn't supported. Thank you!

@FunkyNico does it work with your kernel? What kernel are you using?

My log in case anyone wants to see it:

- Copying zip to temp directory
- Installing high_perf_dac-master.zip
- Current boot slot: _b
- Device is system-as-root
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: module.prop
****************
 High perf DAC 
 by reallyakera 
****************
*******************
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: customize.sh
 Powered by Magisk 
*******************
- Extracting module files
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: LICENSE
  inflating: README.md
  inflating: customize.sh
  inflating: module.prop
  inflating: service.sh
+ print
+ ui_print 
+ true
+ echo 
+ ui_print '• Device : XQ-CQ62'
+ true
+ echo '• Device : XQ-CQ62'
+ ui_print '• Android : 13'
+ true
+ echo '• Android : 13'
+ ui_print '• Hardware : qcom'
+ true
+ echo '• Hardware : qcom'
+ ui_print 
+ true
+ echo 
+ extract
+ ui_print '- Extracting module files'
+ true
+ echo '- Extracting module files'
+ unzip -o /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip module.prop -d /data/adb/modules_update/high_perf_dac
- Done

• Device : XQ-CQ62
• Android : 13
• Hardware : qcom

- Extracting module files
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: module.prop
+ unzip -o /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip service.sh -d /data/adb/modules_update/high_perf_dac
Archive:  /data/user/0/sq.dm.fu.ge.d/cache/flash/install.zip
  inflating: service.sh
+ ui_print '• Codename : '
+ true
+ echo '• Codename : '
+ detect
+ '[' qcom '==' qcom ]
+ ui_print 
+ true
+ echo 
+ ui_print '• ✓ Qcom Detected'
+ true
+ echo '• ✓ Qcom Detected'
+ ui_print 
+ true
+ echo 
+ '[' 
sh: missing ]
+ ui_print 
+ true
+ echo 
+ ui_print '- ! Failed because your Kernel is Not Supported'
+ true
+ echo '- ! Failed because your Kernel is Not Supported'
+ ui_print 
+ true
+ echo 
+ abort
+ ui_print 
+ true
+ echo 
+ true
+ '[' '!' -z /data/adb/modules_update/high_perf_dac ]
+ rm -rf /data/adb/modules_update/high_perf_dac
+ rm -rf /dev/tmp
+ exit 1
• Codename : 

• ✓ Qcom Detected


- ! Failed because your Kernel is Not Supported


! Installation failed

I see that you're using magisk so i don't know it has something do with, but i'm using melon kernel with KSU.
KernelSU_install_log_2023-10-29-00-00-01.log

I don't know for sure if it's working because i didn't see on the logs if it detects that i have qualcomm, and kernel support as you can see. Also for what i hear it sounds good, but i also have audio-jitter-remover and drc-remover.

@theduffster
Copy link

@FunkyNico can you see if you have any of the following folders in /sys/modules? If you do, then it's working as intended.

/sys/module/high_perf_mode
/sys/module/cpe_debug_mode
/sys/module/impedance_detect_en

@FunkyNico
Copy link

FunkyNico commented Nov 10, 2023

@FunkyNico can you see if you have any of the following folders in /sys/modules? If you do, then it's working as intended.

/sys/module/high_perf_mode /sys/module/cpe_debug_mode /sys/module/impedance_detect_en

I do not have any of these folders under /sys/module/. BTW: I will install v5.5 just to check what happens.

@theduffster
Copy link

@FunkyNico As I feared, i think your kernel is not compatible. Thanks for checking!

@FunkyNico
Copy link

Ok i just installed back v5.5 and nothing happens, i attach the log. Then i tried installing other kernel, in this case VelvetKernel r4 for my device and then install back v6, also nothing happens, there's no folders. Greetings.

KernelSU_install_log_2023-11-09-22-47-54.log

@theduffster
Copy link

Damn, that's really too bad. I've been trying to find any recent kernels that have looked at modifying the high performance dac parameters, but unfortunately haven't been able to find a single one for any device.

Hoping to get some time, maybe over the holidays, to look at implementing these older DAC modifications on the WCD9385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants