NodeState.RemoveReference may remove the wrong reference

[einarmo]

Type of issue

• Bug
• Enhancement
• Compliance
• Question
• Help wanted

Current Behavior

NodeState.RemoveReference now removes the first reference that happens to have the requested TargetId, which will often be incorrect. This was changed in #2345, but the fix does not make sense to me.

Expected Behavior

RemoveReference is a public method that is stated to remove the reference defined by (referenceTypeId, isInverse, targetId), which it currently does not do. It also incorrectly reports which reference it did remove.

Steps To Reproduce

myState.AddReference(ReferenceTypeIds.Organizes, false, nodeId);
myState.AddReference(ReferenceTypeIds.GeneratesEvent, false, nodeId);
myState.RemoveReference(ReferenceTypeIds.GeneratesEvent, false, nodeId);
// Throws an exception, due to a conflict.
myState.AddReference(ReferenceTypeIds.GeneratesEvent, false, nodeId);

Environment

- OS: Linux, Fedora
- Environment: CLI
- Runtime: .NET 8
- Nuget Version: 6.8.0.32767
- Component: Opc.Ua.Core
- Server: My own server, but this should be reproducible in the reference server
- Client: None

Anything else?

No response

[mregen]

Hi @einarmo, please check the modified fix and let me know if it is back working.

[einarmo]

This fixes my issue, but it still seems like weird behavior for RemoveReference to do this. It is very unintuitive that it can in some cases remove a different reference from the one you asked to remove, but I don't quite know what #2343 actually is.

[mregen]

I think your opinion is correct. I double checked and it looks like the error happens in another layer. Once verified, we go back to the original code in NodeState. Thanks for checking!

[mregen]

The regression qualifies for a hotfix for .106

[mregen]

see 1.4.372.107