Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make X509CertificateStore support CRLs on Windows #2571

Merged
merged 16 commits into from
Jun 11, 2024

Merge branch 'master' into X509CrlSupport

8272d0d
Select commit
Failed to load commit list.
Refresh
Merged

Make X509CertificateStore support CRLs on Windows #2571

Merge branch 'master' into X509CrlSupport
8272d0d
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Apr 22, 2024 in 0s

54.69% (+0.06%) compared to 60689c9

View this Pull Request on Codecov

54.69% (+0.06%) compared to 60689c9

Details

Codecov Report

Attention: Patch coverage is 59.53757% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 54.69%. Comparing base (60689c9) to head (8272d0d).

Files Patch % Lines
...tificateStore/Extensions/Internal/X509CrlHelper.cs 52.94% 26 Missing and 6 partials ⚠️
...cates/X509CertificateStore/X509CertificateStore.cs 69.69% 8 Missing and 12 partials ⚠️
...CertificateStore/Extensions/X509StoreExtensions.cs 47.61% 4 Missing and 7 partials ⚠️
...tificateStore/Extensions/Internal/PInvokeHelper.cs 33.33% 6 Missing ⚠️
.../X509CertificateStore/Extensions/PlatformHelper.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
+ Coverage   54.62%   54.69%   +0.06%     
==========================================
  Files         342      346       +4     
  Lines       65082    65253     +171     
  Branches    13350    13403      +53     
==========================================
+ Hits        35553    35688     +135     
- Misses      25661    25674      +13     
- Partials     3868     3891      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov