Adapt to change in ert ecl_type. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no objections, merge at will.
yes, I don't mind replacing it with stuff that uses opm-output. the reason this has been added in the first place is that the output code from opm-core was not up to speed at that time and the reason it has not been replaced yet is that this requires some work on stuff which is currently not on my list of priorities. (note that once that is done, the opm-simulators code for ecl output can probably be retired as well.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: OPM/opm-output#176
But - I must admit I was dumbfounded when I stumbled across this code; as it says in a comment: "This code has shamelessly been copy pasted from opm-core". Since then the code in question has been moved to opm-output and refactored massively. I would assume the copy here in ewoms code can and should be retired?