Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo on dashboard no longer left aligned due to w-100 class #3516

Open
Xaraxia opened this issue Apr 18, 2024 · 1 comment · May be fixed by #3568
Open

Logo on dashboard no longer left aligned due to w-100 class #3516

Xaraxia opened this issue Apr 18, 2024 · 1 comment · May be fixed by #3568
Assignees
Labels
bug Existing functionality not working as expected component/dashboard
Milestone

Comments

@Xaraxia
Copy link

Xaraxia commented Apr 18, 2024

The w-100 class is explicitly listed for the logo on the main dashboard home screen, and this class is set to '!important'. This causes the default OnDemand logo to appear in the middle of the screen instead of at the left. (Note - it's also ignoring the default public logo, so documentation is also incorrect, you have to explicitly configure a logo now to override.)

When I use our own SVG, which does have an appropriate width and height, instead of displaying left-adjusted as expected, it fills to the width of the container.

image

Removing the w-100 class causes the dashboard to behave as expected.

image

Similar behaviour occurs if you try to use the existing PNG that comes with OnDemand (the SVG works apart from being centre-aligned):

image

Can we either make these classes configurable, or remove the w-100 class from this logo please?

@osc-bot osc-bot added this to the Backlog milestone Apr 18, 2024
@johrstrom
Copy link
Contributor

Can we either make these classes configurable, or remove the w-100 class from this logo please?

Yea we can fix this and backport it to 3.1.

@johrstrom johrstrom modified the milestones: Backlog, 3.1 Apr 18, 2024
@johrstrom johrstrom added bug Existing functionality not working as expected component/dashboard labels Apr 18, 2024
@HazelGrant HazelGrant self-assigned this May 16, 2024
@HazelGrant HazelGrant linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected component/dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants