Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loginLogo Needs url not a `path #3518

Open
Oglopf opened this issue Apr 18, 2024 · 3 comments
Open

loginLogo Needs url not a `path #3518

Oglopf opened this issue Apr 18, 2024 · 3 comments
Labels
area/auth area/documentation bug Existing functionality not working as expected community request
Milestone

Comments

@Oglopf
Copy link
Contributor

Oglopf commented Apr 18, 2024

We received a discourse today about setting up the loginLogo and getting errors around its rendering.
https://discourse.openondemand.org/t/loginlogo-not-being-found/3429/2

Looking at the docs they shared, it looks like that should only be a path, not a full url like we have documented. It looks to work once you use the url though. It might be we just need to update the docs, but I wanted to check that this isn't a bug first.

@Oglopf Oglopf added bug Existing functionality not working as expected community request area/documentation area/auth labels Apr 18, 2024
@osc-bot osc-bot added this to the Backlog milestone Apr 18, 2024
@johrstrom
Copy link
Contributor

Is this a ticket here or the documentation? Thinking about this a bit - I'll bet it means the URI path not the filesystem path.

I.e., I'm guessing that

loginLogo: "/public/uos_logo_white_small.png"

would have worked instead of specifying the file system path that included /var/www.

@connorourke
Copy link

Having "/public/uos_logo_white_small.png" doesn't seem to work either.

@johrstrom
Copy link
Contributor

It worked for me

image

You can see in the HTML it's the relative URI path.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth area/documentation bug Existing functionality not working as expected community request
Projects
None yet
Development

No branches or pull requests

4 participants