Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make path to /var/www/ood/apps apps directory easily configurable #782

Open
ericfranz opened this issue Jan 4, 2021 · 1 comment
Open
Labels
bug Existing functionality not working as expected community request enhancement This is functionality that builds upon existing functionality.
Milestone

Comments

@ericfranz
Copy link
Contributor

ericfranz commented Jan 4, 2021

Currently the knowledge of where these apps are located is duplicated between nginx_stage and the dashboard app.

As a result, while we could change the location of these apps in nginx_stage.yml the dashboard has the original paths hardcoded:

  • dev:
    def self.base_path(owner: OodSupport::Process.user.name)
    Configuration.dev_apps_root_path
    end
  • sys:
    def self.base_path
    Pathname.new "/var/www/ood/apps/sys"
    end
  • usr:
    def self.base_path(owner: OodSupport::Process.user.name)
    # ood
    Pathname.new "/var/www/ood/apps/usr/#{owner}/gateway"
    # dev
    # Pathname.new Rails.root.join("data", "apps","usr", owner)
    # awesim
    # Pathname.new(Dir.home).join("awesim_shared_apps")
    end
    def self.owners
    owners = []
    # ood
    target = Pathname.new("/var/www/ood/apps/usr")
    owners = target.children(false).map(&:to_s) if target.directory? && target.executable? && target.readable?
    # dev
    # owners = Rails.root.join("data", "apps","usr").children(false).map(&:to_s)
    # awesim
    # owners = ["awe0011", "efranz", "jnicklas"]
    owners
    end

Removing this duplication would help.

Another approach would be to shift the scanning of apps users can launch to nginx_stage, generating the app configs dynamically like we generate the nginx_stage config.

┆Issue is synchronized with this Asana task by Unito

@oscwiag oscwiag added this to the Needs Triaged milestone Jan 4, 2021
@KinanAlAttar KinanAlAttar self-assigned this Jan 4, 2021
@johrstrom johrstrom modified the milestones: Needs Triaged, Backlog Jan 5, 2021
@KinanAlAttar KinanAlAttar removed their assignment Jan 26, 2021
@lukew3 lukew3 added the enhancement This is functionality that builds upon existing functionality. label Jul 19, 2022
@Oglopf Oglopf added bug Existing functionality not working as expected community request labels Apr 18, 2024
@Oglopf
Copy link
Contributor

Oglopf commented Apr 18, 2024

This issue should be labeled bug as we say the sys path can be configured in our docs, but it can't. We've also had a user bring this to our attention on the discourse and request that it get fixed.

https://discourse.openondemand.org/t/change-sys-apps-path/3425/3

Adding some tags to prioritize the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected community request enhancement This is functionality that builds upon existing functionality.
Projects
None yet
Development

No branches or pull requests

6 participants