Slurm gpus_from_gres not quite right

[johrstrom]

If that is kept, I think that regex is wrong. Where it might cause issues:

gres/gpu:v100-32g=2

That's a GRES definition on Pitzer, numbers are in the subtype. Depending on where you query the GRES, ie which command, you could also split on = and get last element.

Originally posted by treydock in #752 (comment)

┆Issue is synchronized with this Asana task by Unito

[johrstrom]

This is the method that this ticket is about:

ood_core/lib/ood_core/job/adapters/slurm.rb

Lines 620 to 622 in b311447

	def gpus_from_gres(gres)
	gres.to_s.scan(/gpu:[^,]*(\d+)/).flatten.map(&:to_i).sum
	end

Looks like /gpu:[^,]*(\d+),{,1}/ could work. @treydock seems like we're only interested in the very last digit(s) whatever that maybe.

We could split(',') and capture from the end of the line $ (positive lookbehind isn't implemented Ruby) but I don't know if I like chaining a splits together.

[lukew3]

I'm pretty sure that the regex still works. Check out the tests I added in #754. The regex is grabbing the last set of digits after gpu: and before , or the end of the string.

[johrstrom]

Yep, I added similar test cases, but didn't check to see if they worked. In any case, yes with new tests there's nothing to do.