Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Batch#submit_string should pipe script to stdin of Open3.capture3 #26

Open
ericfranz opened this issue Jun 21, 2017 · 2 comments
Open

Comments

@ericfranz
Copy link
Contributor

Instead it creates a temporary file and passes the path:

pbs-ruby/lib/pbs/batch.rb

Lines 300 to 307 in 7ce6f96

# @return [String] the id of the job that was created
def submit_string(string, **kwargs)
Tempfile.open('qsub.') do |f|
f.write string.to_s
f.close
submit_script(f.path, **kwargs)
end
end

@nickjer
Copy link
Contributor

nickjer commented Jun 22, 2017

I am not aware of how to submit a script from stdin through a library call. And writing it to a temporary file followed by a job submission through qsub or the library works in both cases. So I found it unnecessary at the time to handle both cases in different manners.

@nickjer
Copy link
Contributor

nickjer commented Jun 22, 2017

Did you experience any issues with this? If so I can definitely handle things different depending on mechanism used to submit jobs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants