Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Change how env vars are passed #28

Open
nickjer opened this issue Sep 6, 2017 · 1 comment
Open

Change how env vars are passed #28

nickjer opened this issue Sep 6, 2017 · 1 comment
Assignees

Comments

@nickjer
Copy link
Contributor

nickjer commented Sep 6, 2017

Instead of passing environment variables as:

qsub -v "TEST1=123,TEST2=321"

a better alternative may be...

TEST1=123 TEST2=321 qsub -v "TEST1,TEST2"

this would allow for more oddly formatted variables (has quotes, commas, or equals) that would probably fail in the former case:

export TEST1="inject,ANOTHER=variable"
export TEST2="321"

# This will work!
qsub -v "TEST1,TEST2"
@nickjer nickjer self-assigned this Sep 6, 2017
@nickjer
Copy link
Contributor Author

nickjer commented Sep 6, 2017

Note, I need to test the above, as the above is just an educated guess right now.

Implementation will be same how Slurm handles it:

https://github.com/OSC/ood_core/blob/a629283bd59cfc4d6dbebce79c0415094080d928/lib/ood_core/job/adapters/slurm.rb#L294-L296

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant